Skip to content

[AKS] Add auto upgrade channel to aks create and update#2694

Merged
arrownj merged 15 commits intoAzure:masterfrom
xhl873:xhl/upgradechannel2
Nov 26, 2020
Merged

[AKS] Add auto upgrade channel to aks create and update#2694
arrownj merged 15 commits intoAzure:masterfrom
xhl873:xhl/upgradechannel2

Conversation

@xhl873
Copy link
Contributor

@xhl873 xhl873 commented Nov 18, 2020

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@azuresdkci
Copy link

azuresdkci commented Nov 18, 2020

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it mcr.microsoft.com/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/xhl873/azure-cli-extensions.git@xhl/upgradechannel2#subdirectory=src/$EXT&egg=$EXT"

paulgmiller
paulgmiller approved these changes Nov 18, 2020
View reviewed changes
@yonzhan
Copy link
Collaborator

yonzhan commented Nov 18, 2020

AKS

charliedmcb
charliedmcb approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@charliedmcb charliedmcb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Although, I don't know the area well enough to say with certainty :)

There are also a few failing checks that need to be resolved.

@xhl873
Copy link
Contributor Author

xhl873 commented Nov 18, 2020

Looks good to me. Although, I don't know the area well enough to say with certainty :)

There are also a few failing checks that need to be resolved.

yea, I am aware of the failures, waiting for Bo's PR to vendor 11-01 API, and there are a couple of test fixes also. I need to merge once that change is in (I have vendored that locally for testing purpose.)

arrownj
arrownj reviewed Nov 19, 2020
View reviewed changes
Copy link
Contributor

@arrownj arrownj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a possibility to add test for this new parameter ?

src/aks-preview/azext_aks_preview/_consts.py
CONST_RAPID_UPGRADE_CHANNEL = "rapid"
CONST_STABLE_UPGRADE_CHANNEL = "stable"
CONST_PATCH_UPGRADE_CHANNEL = "patch"
CONST_NONE_UPGRADE_CHANNEL = "none"
Copy link
Contributor

@arrownj arrownj Nov 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these values defined in the swagger and have been defined as Enum in the SDK ? If yes, we may be able to leverage it instead of defining separately.

Copy link
Contributor Author

@xhl873 xhl873 Nov 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are defined in the swagger, however, consts file does depend on the versioned SDK, not sure if it's the reason that we are defining these consts here (don't want to introduce dependency?). Probably I am going to break the pattern and keep it consistent for now. :)

@arrownj arrownj self-assigned this Nov 19, 2020
@xhl873
Copy link
Contributor Author

xhl873 commented Nov 19, 2020

Is there a possibility to add test for this new parameter ?

yes, I've added a test (and recording), please take a look

@paulgmiller
Copy link

paulgmiller commented Nov 25, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 25, 2020

Commenter does not have sufficient privileges for PR 2694 in repo Azure/azure-cli-extensions

@yungezz
Copy link
Member

yungezz commented Nov 25, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 25, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@arrownj arrownj merged commit 103dc2c into Azure:master Nov 26, 2020
@charliedmcb charliedmcb mentioned this pull request Jul 13, 2021
Merged
3 tasks
@FumingZhang FumingZhang mentioned this pull request Aug 20, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gtracer gtracer Awaiting requested review from gtracer

@zqingqing1 zqingqing1 Awaiting requested review from zqingqing1

4 more reviewers

@paulgmiller paulgmiller paulgmiller approved these changes

@arrownj arrownj arrownj approved these changes

@charliedmcb charliedmcb charliedmcb approved these changes

@yungezz yungezz yungezz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@arrownj arrownj

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@xhl873 @azuresdkci @yonzhan @paulgmiller @yungezz @arrownj @charliedmcb